Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Allow Java devices to customize action errors
23-08-2012, 08:24 AM (This post was last modified: 23-08-2012 08:47 AM by simonc.)
Post: #13
RE: Allow Java devices to customize action errors
You're not getting much of a break on your holiday Wink

(22-08-2012 10:20 PM)simoncn Wrote:  I've found a small typo in the code changes for Invocation.c. In line 172:
I've fixed this locally; it should be on github this evening.

(22-08-2012 10:20 PM)simoncn Wrote:  I've also tracked down the reason for double-spacing in code sections where recent patches have been applied. If a file contains a mixture of Unix-style LF line endings and Windows-style CR/LF line endings, the text editor I'm using displays the CR/LF lines as double-spaced. I've produced the recent patches using Windows, so the code I've provided has contained CR/LF line endings, but the files on Github seem to use LF line endings as the standard.

Do you see this problem when you view lines 137 through 192 of Invocation.c in a test editor? It affects a few other places as well, and I'd be happy to produce a complete list of these.

I was prompted to fix the line endings in Invocation.c when I applied your suggested change so this file is consistent again. Don't worry about listing other files - the check_ws.py script in the ohdevtools repo will do this (and optionally fix them) for us. I've been periodically running it to fix line endings. We'll probably change to using pre-commit rules to validate line endings in future.
Find all posts by this user


Messages In This Thread
RE: Allow Java devices to customize action errors - simonc - 23-08-2012 08:24 AM

Forum Jump: