Property change notification doesn't work for Java

[simoncn]

If a Java control point tries to set a notification for a change to a single named property, the property change listener is never called. A workaround is to listen for changes to all properties (which does work), but this is inefficient if only one property has changed.

The fix is in the generated Java proxy code. In the constructor, instead of code like this for a property Foo:

Code:

iFooChanged = new PropertyChangeListener();
iFoo = new PropertyString("Foo", iFooChanged);
addProperty(iFoo);

the code should be like this:

Code:

iFooChanged = new PropertyChangeListener() {
    public void notifyChange() {
        fooPropertyChanged();
    }
};
iFoo = new PropertyString("Foo", iFooChanged);
addProperty(iFoo);

[simonc]

Thanks for debugging this! I'll get a fix committed tomorrow.

[simonc]

Unit tests get into stack overflowing loops after this change.

I updated the T4 template CpUpnpJava.tt with the generic version of the fix you suggested, rebuilt and ran TestDvDeviceJava. It gives pages of output of the form

Code:

at org.openhome.net.controlpoint.CpProxy.reportEvent(CpProxy.java:168)
        at org.openhome.net.controlpoint.proxies.CpProxyOpenhomeOrgTestBasic1.varUintProper​tyChanged(CpProxyOpenhomeOrgT
estBasic1.java:1600)
        at org.openhome.net.controlpoint.proxies.CpProxyOpenhomeOrgTestBasic1.access$000(Cp​ProxyOpenhomeOrgTestBasic1.ja
va:430)
        at org.openhome.net.controlpoint.proxies.CpProxyOpenhomeOrgTestBasic1$1.notifyChang​e(CpProxyOpenhomeOrgTestBasic
1.java:567)
        at org.openhome.net.controlpoint.CpProxy.reportEvent(CpProxy.java:168)
        at org.openhome.net.controlpoint.proxies.CpProxyOpenhomeOrgTestBasic1.varUintProper​tyChanged(CpProxyOpenhomeOrgT
estBasic1.java:1600)
        at org.openhome.net.controlpoint.proxies.CpProxyOpenhomeOrgTestBasic1.access$000(Cp​ProxyOpenhomeOrgTestBasic1.ja
va:430)
        at org.openhome.net.controlpoint.proxies.CpProxyOpenhomeOrgTestBasic1$1.notifyChang​e(CpProxyOpenhomeOrgTestBasic
1.java:567)
        at org.openhome.net.controlpoint.CpProxy.reportEvent(CpProxy.java:168)

[simoncn]

My apologies. The correct code is as follows:

Code:

iFooChanged = new PropertyChangeListener();
iFoo = new PropertyString("Foo",
           new PropertyChangeListener() {
               public void notifyChange() {
                   fooPropertyChanged();
               }
           }
       );
addProperty(iFoo);

I believe the previous code worked when the control point had set a change listener for the Foo property (which was the case that I tested), but not when the control point had only set a generic property change listener (as in the test case). I've tested this version of the code to make sure that it's OK in both cases.

[simonc]

Thanks, that seems better.

I've committed this locally now. The changes will hopefully make it onto github this evening.

[simoncn]

(19-04-2012 04:06 PM)simonc Wrote:  Thanks, that seems better.

I've committed this locally now. The changes will hopefully make it onto github this evening.

Thanks very much for the quick fix!