Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Allow Java devices to customize action errors
22-08-2012, 10:20 PM
Post: #12
RE: Allow Java devices to customize action errors
(13-08-2012 08:44 AM)simonc Wrote:  Thanks. I've applied these locally so they should be on github this evening.

I've found a small typo in the code changes for Invocation.c. In line 172:
Code:
printf("Unable to find constructor for class org/openhome/net/controlpoint/proxyError\n");
'proxyError' should be 'ProxyError'. It's only an error message, so it doesn't affect the correct functioning of the code, but it can be confusing if this error message is displayed (as it was for me during recent testing).

I've also tracked down the reason for double-spacing in code sections where recent patches have been applied. If a file contains a mixture of Unix-style LF line endings and Windows-style CR/LF line endings, the text editor I'm using displays the CR/LF lines as double-spaced. I've produced the recent patches using Windows, so the code I've provided has contained CR/LF line endings, but the files on Github seem to use LF line endings as the standard.

Do you see this problem when you view lines 137 through 192 of Invocation.c in a test editor? It affects a few other places as well, and I'd be happy to produce a complete list of these.
Find all posts by this user


Messages In This Thread
RE: Allow Java devices to customize action errors - simoncn - 22-08-2012 10:20 PM

Forum Jump: